feat: switch VirtualTable producer to use expressions field instead of deprecated values#23672
Open
eliot1480 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #23672 +/- ##
=======================================
Coverage 80.66% 80.67%
=======================================
Files 1086 1086
Lines 366673 366740 +67
Branches 366673 366740 +67
=======================================
+ Hits 295786 295853 +67
+ Misses 53263 53261 -2
- Partials 17624 17626 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vbarua
reviewed
Jul 20, 2026
vbarua
reviewed
Jul 20, 2026
vbarua
left a comment
vbarua
left a comment
Contributor
There was a problem hiding this comment.
Thinking about this from a migration perspective, I think we need to do ship this as 2 changes:
- Release a change that switches the producer to generate VirtualTables using only the
expressionsfield. - After that is live, release the change that fully removes the old
valuesfield.
Because the producer currently emits plans using the deprecated field, we need to give users a chance to update any stored plans, and then remove support for values.
eliot1480
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Since the VirtualTables.values field has been deprecated and is soon to be removed in the next substrait update, we should make sure to delete all instances of it to prevent the presence of dead code.
This PR switches the producer to generate VirtualTables using only the expressions field. A later PR will be released to fully remove all instances of the
valuesfield. The reason removal will be separate is because we want to give users a chance to update any stored plans, and then remove values.The consumer also needed an update, because since the producer only emits expressions, a new gap was introduced where expressions never uses named_struct.names to rename nested fields (structs/lists) the way the values/literal path does. So for flat/scalar columns, expressions would work fine, but for struct/list-typed columns, the consumer would silently drop original nested field names and fall back to positional defaults.
What changes are included in this PR?
Producer now emits VirtualTable.expressions for Values and EmptyRelation. Converted 17 direct virtualTable.values entries across 10 JSON test plans to virtualTable.expressions. Consumer now adds support for struct field-name preservation when reading from only expressions.
Are these changes tested?
Yes they are. Tests ran:
jq validation for JSON fixtures
Are there any user-facing changes?
No.